Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending email for notify reward amount #99

Merged
merged 5 commits into from
Jul 2, 2024
Merged

sending email for notify reward amount #99

merged 5 commits into from
Jul 2, 2024

Conversation

ae2079
Copy link
Contributor

@ae2079 ae2079 commented Jun 18, 2024 •
edited
Loading

Add fields for the notify reward amount notification from giv-token-contracts service
related to: Giveth/giveth-dapps-v2#4194

ae2079
ae2079 commented Jun 20, 2024
View reviewed changes
migrations/1718888344202-seedNotificationTypeForNotifyRewardAmount.ts

const NotifyRewardAmountNotificationType = [
{
name: NOTIFICATION_TYPE_NAMES.NOTIFY_REWARD_AMOUNT,
Copy link
Contributor Author

@ae2079 ae2079 Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammadranjbarz
I ran the migration and these fields are set successfully, but I am not sure about the correctness of their values and I don't know if I should put other fields too, or not

mohammadranjbarz
mohammadranjbarz approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ae2079, LGTM (we can merge it once we can test it together after deployment)

RamRamez
RamRamez requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@RamRamez RamRamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ae2079 You need to add notifyRewardAmount to SEGMENT_METADATA_SCHEMA_VALIDATOR to make it work.

@ae2079
Copy link
Contributor Author

ae2079 commented Jul 2, 2024

@ae2079 You need to add notifyRewardAmount to SEGMENT_METADATA_SCHEMA_VALIDATOR to make it work.

Done, thank you Ramin

RamRamez
RamRamez approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@RamRamez RamRamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ae2079

@mohammadranjbarz mohammadranjbarz merged commit 8087902 into staging Jul 2, 2024
3 checks passed
@mohammadranjbarz mohammadranjbarz deleted the 4194-sending-email-for-givpower branch July 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamRamez RamRamez RamRamez approved these changes

@mohammadranjbarz mohammadranjbarz mohammadranjbarz approved these changes

Assignees
No one assigned
Labels
QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ae2079 @mohammadranjbarz @RamRamez @divine-comedian